REFACTOR: add asset_type query parameter to getDataDocs and separate data docs methods

This commit is contained in:
viniciusgadea
2025-12-10 11:21:46 -03:00
parent 165b533172
commit 09dced9fcd
2 changed files with 20 additions and 17 deletions
+18 -10
View File
@@ -340,10 +340,8 @@ class CatalogService implements OnModuleInit {
}
async getDataDocs(id: string, assetType: string, metadata: Metadata) {
const requestType = assetType === 'dataset' ? undefined : assetType;
const { documentation } = await lastValueFrom(
this.catalogReadService.GetDatasetDoc({ id, type: requestType }, metadata),
this.catalogReadService.GetDatasetDoc({ id }, metadata),
);
const docs = JSON.parse(documentation);
@@ -374,14 +372,24 @@ class CatalogService implements OnModuleInit {
async createDataDocs(body: CreateDataDocsDTO, metadata: Metadata) {
if (body.asset_type === 'table' || body.asset_type === 'view') {
const nimbusUrl = this._getNimbusUrl(body);
const { data } = await axios.post(
`${nimbusUrl}/api/catalog/data-docs/`,
body,
);
return data;
return this.createDataDocsViaNimbus(body);
}
return this.createDataDocsViaGrpc(body, metadata);
}
private async createDataDocsViaNimbus(body: CreateDataDocsDTO) {
this.logger.info('Creating data docs via Nimbus for table/view');
const nimbusUrl = this._getNimbusUrl(body);
const { data } = await axios.post(
`${nimbusUrl}/api/catalog/data-docs/`,
body,
);
return data;
}
private async createDataDocsViaGrpc(body: CreateDataDocsDTO, metadata: Metadata) {
this.logger.info('Creating data docs via gRPC for other asset types');
try {
const response: any = await lastValueFrom(
this.catalogWriteService.UpdateDataAssetDoc(