FIX: add logic for fetching shared data_assets

src/modules/catalog/catalog.controller.ts

@@ -1,11 +1,14 @@
 import {
+  BadRequestException,
   Body,
   Controller,
   Delete,
+  ForbiddenException,
   Get,
   Headers,
   HttpException,
   Inject,
+  NotFoundException,
   Param,
   Post,
   Put,
@@ -98,7 +101,7 @@ export class CatalogController {
     });
 
     if (!pipeline || !object) {
-      throw new HttpException('Query params not provided', 400);
+      throw new BadRequestException('Query params not provided');
     }
 
     const is_data_manager = permissions.includes(
@@ -136,9 +139,8 @@ export class CatalogController {
       return { data_asset };
     }
 
-    throw new HttpException(
+    throw new ForbiddenException(
       'You do not have permission to access this data asset.',
-      403,
     );
   }
 
@@ -172,12 +174,12 @@ export class CatalogController {
   )
   async getDataAsset(
     @User() user: RequestUser,
-    @Headers() headers,
     @Param('id') id,
+    @Query('shared') shared?: 'true',
   ) {
     const { username, user_id, customer_id, customer_name, permissions } = user;
 
-    this.logger.info(`/catalog - ON GET ONE DASHBOARD METABASE ROUTE`, {
+    this.logger.info(`GET /data-asset/${id}`, {
       username,
       customer_name,
     });
@@ -200,25 +202,24 @@ export class CatalogController {
       id,
       metadata,
     });
+    has_permission =
+      is_data_manager ||
+      data_asset?.owner === username ||
+      (user_roles as Array<any>).some((r) => data_asset.p_roles.includes(r)) ||
+      data_asset.p_users.includes(user_id);
+    if (
+      shared === 'true' &&
+      (data_asset.share_type === undefined || data_asset.share_type === 'none')
+    )
+      throw new NotFoundException();
+    if (!has_permission)
+      throw new ForbiddenException(
+        'You do not have permission to access this data asset.',
+      );
+    delete data_asset.p_roles;
+    delete data_asset.p_users;
 
-    if (data_asset?.owner === username) has_permission = true;
-
-    for (const role of user_roles) {
-      if (data_asset.p_roles.includes(role)) has_permission = true;
-    }
-
-    if (data_asset.p_users.includes(user_id)) has_permission = true;
-
-    if (is_data_manager || has_permission) {
-      delete data_asset.p_roles;
-      delete data_asset.p_users;
-      return { data_asset };
-    }
-
-    throw new HttpException(
-      'You do not have permission to access this data asset.',
-      403,
-    );
+    return { data_asset };
   }
 
   @Get('data-asset/rls/:id')
@@ -271,9 +272,8 @@ export class CatalogController {
       return { data_asset };
     }
 
-    throw new HttpException(
+    throw new ForbiddenException(
       'You do not have permission to access this data asset.',
-      403,
     );
   }
 
@@ -376,7 +376,7 @@ export class CatalogController {
   async updateDataAsset(
     @User() user: RequestUser,
     @Headers('Dadosfera-Lang') language,
-    @Param('id') id,
+    @Param('id') data_asset_id,
     @Body() body: IUpdateDataRequest,
   ): Promise<IOneDataAsset> {
     const { customer_id, customer_name, user_id, username } = user;
@@ -390,7 +390,7 @@ export class CatalogController {
 
     const result = await this.catalogService.updateOneDataAsset({
       body,
-      data_asset_id: id,
+      data_asset_id,
       customer_id,
       metadata,
     });