Compare commits

...
Author SHA1 Message Date
iruy-fr f78c5a00dd FIX: surface failed MFA resets 2026-09-03 16:44:47 -03:00
Rafael Santana ec39b82843 Merge pull request #518 from dadosfera/feature/cdc-connector
FIX: CDC live status decodes int64 offsets as numbers
2026-08-31 17:07:20 -03:00
RafaelandWOZCODE 20d3532c0f FIX: address review round 2 on the CDC refactor
- toCdcTable accepts the source table named either table_name (platform
  bodies) or name (create DTO), so call sites pass it point-free:
  body.tables.map(toCdcTable). The identity is still derived in one place.
- PipelineTablesService declares its logger like every other maestro service
  (logger: DadosferaLogger assigned from the injected instance).

Co-Authored-By: WOZCODE <contact@withwoz.com>
2026-08-31 16:09:25 -03:00
Rafael Santana 9457fcc85e Merge pull request #519 from dadosfera/refactor/cdc-review
UPDATE: apply the CDC code-review policy (maestro #510)
2026-08-31 12:52:51 -03:00
Rafael Santana 1400df0ab9 Merge pull request #510 from dadosfera/feature/cdc-connector
Feature/cdc connector
2026-08-28 13:36:54 -03:00
5 changed files with 84 additions and 8 deletions
@@ -0,0 +1,57 @@
import { HttpException, HttpStatus } from '@nestjs/common';
import { Metadata } from '@grpc/grpc-js';
import { of } from 'rxjs';
import { AuthClientService } from './auth.service';
describe('AuthClientService.resetUsers', () => {
const logger = {
info: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
};
const resetUser = jest.fn();
let service: AuthClientService;
beforeEach(() => {
jest.clearAllMocks();
service = new AuthClientService({ logger } as any, {} as any);
(service as any).authService = { ResetUser: resetUser };
});
it('returns the DUC response when every requested user was reset', async () => {
const response = {
message: 'Users reset successfully',
successfulUsers: ['user-1'],
failedUsers: [],
};
resetUser.mockReturnValue(of(response));
await expect(
service.resetUsers(['user-1'], new Metadata()),
).resolves.toEqual(response);
});
it('returns a non-2xx error instead of masking failed resets', async () => {
const response = {
message: 'Some users failed',
successfulUsers: ['user-1'],
failedUsers: ['user-2'],
};
resetUser.mockReturnValue(of(response));
try {
await service.resetUsers(['user-1', 'user-2'], new Metadata());
fail('Expected resetUsers to reject');
} catch (error) {
expect(error).toBeInstanceOf(HttpException);
expect((error as HttpException).getStatus()).toBe(HttpStatus.BAD_GATEWAY);
expect((error as HttpException).getResponse()).toEqual({
statusCode: HttpStatus.BAD_GATEWAY,
message: 'Failed to reset MFA for one or more users.',
successfulUsers: ['user-1'],
failedUsers: ['user-2'],
});
}
});
});
+16
View File
@@ -295,6 +295,22 @@ export class AuthClientService implements OnModuleInit {
this.authService.ResetUser({ users }, metadata),
);
if (response.failedUsers?.length > 0) {
this.logger.error('resetUsers - Partial or total failure', {
successfulUsers: response.successfulUsers,
failedUsers: response.failedUsers,
});
throw new HttpException(
{
statusCode: HttpStatus.BAD_GATEWAY,
message: 'Failed to reset MFA for one or more users.',
successfulUsers: response.successfulUsers,
failedUsers: response.failedUsers,
},
HttpStatus.BAD_GATEWAY,
);
}
this.logger.info('resetUsers - Success', { response });
return response;
} catch (error) {
+9 -4
View File
@@ -3,11 +3,15 @@ import {
CdcTable,
} from '@dadosfera/protospack-v2/dist/lib/Input/interfaces/entities';
/** What a caller knows about a CDC table before it is stored. */
/** What a caller knows about a CDC table before it is stored. The source
* table is named `table_name` on the platform-facing bodies and `name` on
* the create DTO (CdcTableReq); either works — deriving one from the other
* happens only here. */
export interface CdcTableInput {
// Optional on the create DTO (CdcTableReq); the platform validates it.
table_schema?: string;
table_name: string;
table_name?: string;
name?: string;
primary_keys?: string[];
iceberg_table_name?: string;
iceberg_qualify_table_name?: string;
@@ -25,10 +29,11 @@ export interface CdcTableInput {
* `name ?? table_name`).
*/
export function toCdcTable(table: CdcTableInput): CdcTable {
const tableName = table.table_name ?? table.name;
return {
table_schema: table.table_schema,
table_name: table.table_name,
name: table.table_name,
table_name: tableName,
name: tableName,
primary_keys: table.primary_keys ?? [],
iceberg_table_name: table.iceberg_table_name,
iceberg_qualify_table_name: table.iceberg_qualify_table_name,
+1 -3
View File
@@ -196,9 +196,7 @@ export class InputsService {
name: body.name,
plugin: body.plugin,
read_only: body.read_only ?? true,
tables: body.tables.map((t) =>
toCdcTable({ ...t, table_name: t.name }),
),
tables: body.tables.map(toCdcTable),
destination: body.destination,
},
info,
@@ -30,7 +30,7 @@ interface PlatformPipeline {
*/
@Injectable()
export class PipelineTablesService {
private logger: DadosferaLogger['logger'];
logger: DadosferaLogger;
constructor(
private readonly platformApiService: PlatformApiService,