Merge pull request #144 from dadosfera/fix/delete-connection-permission

FIX: delete connection permission

src/authentication/permissions.enum.ts

@@ -125,17 +125,16 @@ export const PERMISSIONS_GROUPS = {
           'es-es': 'Crear Source',
         },
       },
-      //TODO descomentar quando tiver ok o DELETE de conexões
-      // DELETE: {
-      //   seqid: 38,
-      //   claim: 'connection:delete',
-      //   usage: PermissionUsages.PUBLIC,
-      //   name: {
-      //     'pt-br': 'Excluir Fonte',
-      //     'en-us': 'Remove Source',
-      //     'es-s': 'Eliminar Source',
-      //   },
-      // },
+      DELETE: {
+        seqid: 38,
+        claim: 'connection:delete',
+        usage: PermissionUsages.INTERNAL,
+        name: {
+          'pt-br': 'Excluir Fonte',
+          'en-us': 'Remove Source',
+          'es-s': 'Eliminar Source',
+        },
+      },
       UPDATE: {
         seqid: 39,
         claim: 'connection:update',

src/modules/catalog/catalog.service.ts

@@ -110,7 +110,7 @@ class CatalogService implements OnModuleInit {
   }
 
   async getUserRolesIds(userId: string) {
-    const result = await this.userService.findOneById(userId);
+    const result = await this.userService.findOneById(userId).catch(() => null);
 
     const roles_ids = result.user.roles.map((role) => role.id);
 
@@ -139,7 +139,7 @@ class CatalogService implements OnModuleInit {
       const condition =
         asset.owner && !asset.owner.includes('@') ? true : false;
       const result = condition
-        ? await this.userService.findOneById(asset.owner)
+        ? await this.userService.findOneById(asset.owner).catch(() => null)
         : null;
 
       const owner = result !== null ? result.user.username : null;
@@ -151,7 +151,7 @@ class CatalogService implements OnModuleInit {
       const condition =
         asset.owner && !asset.owner.includes('@') ? true : false;
       const result = condition
-        ? await this.userService.findOneById(asset.owner)
+        ? await this.userService.findOneById(asset.owner).catch(() => null)
         : null;
 
       const owner = result !== null ? result.user.username : null;
@@ -177,7 +177,9 @@ class CatalogService implements OnModuleInit {
     const opensearchTable = JSON.parse(data_asset);
 
     const result = opensearchTable.user_id
-      ? await this.userService.findOneById(opensearchTable.owner)
+      ? await this.userService
+          .findOneById(opensearchTable.owner)
+          .catch(() => null)
       : null;
 
     const owner = result !== null ? result.user.username : null;
@@ -213,7 +215,9 @@ class CatalogService implements OnModuleInit {
       );
       const opensearchTable = JSON.parse(data_asset);
       const result = opensearchTable.user_id
-        ? await this.userService.findOneById(opensearchTable.owner)
+        ? await this.userService
+            .findOneById(opensearchTable.owner)
+            .catch(() => null)
         : null;
 
       const owner = result !== null ? result.user.username : null;

src/modules/connection/connection.controller.ts

@@ -105,29 +105,29 @@ export class ConnectionController {
     return response;
   }
 
-  // @Delete('/:id')
-  // @RequireAllPermissions(connectionPermissions.DELETE)
-  // async deleteConnection(
-  //   @User() user: RequestUser,
-  //   @Param('id') id: string,
-  // ): Promise<ConnectionRes> {
-  //   this.logger.info('/connections - Delete Connection');
+  @Delete('/:id')
+  @RequireAllPermissions(connectionPermissions.DELETE)
+  async deleteConnection(
+    @User() user: RequestUser,
+    @Param('id') id: string,
+  ): Promise<ConnectionRes> {
+    this.logger.info('/connections - Delete Connection');
 
-  //   const { user_id, customer_id, customer_name, username } = user;
-  //   const metadata = PackTheMetadata({
-  //     user_id,
-  //     customer_id,
-  //     customer_name,
-  //     username,
-  //   });
+    const { user_id, customer_id, customer_name, username } = user;
+    const metadata = PackTheMetadata({
+      user_id,
+      customer_id,
+      customer_name,
+      username,
+    });
 
-  //   const response: any = await this.clientService.deleteConnection({
-  //     body: { id },
-  //     metadata,
-  //   });
+    const response: any = await this.clientService.deleteConnection({
+      body: { id },
+      metadata,
+    });
 
-  //   return response;
-  // }
+    return response;
+  }
 
   @Get()
   async getAllConnections(