fix: add content scope to HubSpot OAuth

FIX: sync proto

deploy/helm-chart/values.yaml

@@ -56,6 +56,8 @@ maestro:
   redis_tls: "true"
   cookie_secret: "13cc5e136d3074bcc05bec8697092ec1f5f376bf"
   firebase_base_url: https://feature-flag-25bf6-default-rtdb.firebaseio.com/prd
+  connections_api_url: https://wv6fw7ayj4.execute-api.us-east-1.amazonaws.com
+
 autoscaling:
   enabled: false
   minReplicas: 1

package-lock.json

@@ -16,7 +16,7 @@
         "@aws-sdk/lib-dynamodb": "^3.414.0",
         "@aws-sdk/signature-v4": "^3.370.0",
         "@dadosfera/dadosfera-logs": "^1.0.0-beta.4",
-        "@dadosfera/protospack-v2": "^3.40.0-beta.14",
+        "@dadosfera/protospack-v2": "3.40.0",
         "@grpc/grpc-js": "^1.9.3",
         "@grpc/proto-loader": "^0.7.9",
         "@nestjs/cli": "^9.5.0",
@@ -1735,9 +1735,10 @@
       }
     },
     "node_modules/@dadosfera/protospack-v2": {
-      "version": "3.40.0-beta.14",
-      "resolved": "https://dadosfera-611330257153.d.codeartifact.us-east-1.amazonaws.com/npm/dadosfera-npm/@dadosfera/protospack-v2/-/protospack-v2-3.40.0-beta.14.tgz",
-      "integrity": "sha512-pv3pxq0x1XcBgf3ajD6QOFRLOduh8iEozKFA3AKlIW4gid+gT4iL0GcU2M+O7h0QFeO4JIzRZe/nEMN82nqk7A==",
+      "version": "3.40.0",
+      "resolved": "https://dadosfera-611330257153.d.codeartifact.us-east-1.amazonaws.com/npm/dadosfera-npm/@dadosfera/protospack-v2/-/protospack-v2-3.40.0.tgz",
+      "integrity": "sha512-tzYAGosFjGUgi3pAvXqv+Eqqjca9tH1kU9kJdRI5d1rLXNimo0fIuPWxWng0C4OBH/2sIgC1WLHseq+DZ6qgdw==",
+      "license": "ISC",
       "dependencies": {
         "@grpc/grpc-js": "^1.9.3",
         "rxjs": "^7.5.5"

package.json

@@ -34,7 +34,7 @@
     "@aws-sdk/lib-dynamodb": "^3.414.0",
     "@aws-sdk/signature-v4": "^3.370.0",
     "@dadosfera/dadosfera-logs": "^1.0.0-beta.4",
-    "@dadosfera/protospack-v2": "^3.40.0-beta.14",
+    "@dadosfera/protospack-v2": "3.40.0",
     "@grpc/grpc-js": "^1.9.3",
     "@grpc/proto-loader": "^0.7.9",
     "@nestjs/cli": "^9.5.0",

src/modules/oauth/passport-strategies/hubspot-strategy.spec.ts

@@ -0,0 +1,59 @@
+let mockStrategyOptions: { scope: string };
+
+jest.mock('passport-hubspot-oauth2', () => ({
+  Strategy: class {
+    constructor(options: { scope: string }) {
+      mockStrategyOptions = options;
+    }
+
+    authenticate() {}
+  },
+}));
+
+jest.mock('@nestjs/passport', () => ({
+  PassportStrategy: (Strategy) => Strategy,
+}));
+
+import { HubspotStrategy } from './hubspot-strategy';
+import type { OauthSecrets } from 'src/utils/OauthSecrets';
+import type { OauthService } from '../oauth.service';
+
+describe('HubspotStrategy', () => {
+  it('requests the content scope without requesting Marketing write scopes', () => {
+    const oauthSecrets = {
+      hubspot: {
+        client_id: '',
+        client_secret: '',
+        redirect_uri: '',
+      },
+    } as OauthSecrets;
+
+    new HubspotStrategy(oauthSecrets, {} as OauthService);
+
+    const scopes = mockStrategyOptions.scope.split(' ');
+
+    expect(scopes).toEqual([
+      'tickets',
+      'automation',
+      'business-intelligence',
+      'oauth',
+      'forms',
+      'content',
+      'integration-sync',
+      'sales-email-read',
+      'crm.lists.read',
+      'crm.objects.contacts.read',
+      'crm.schemas.contacts.read',
+      'crm.objects.companies.read',
+      'crm.objects.deals.read',
+      'crm.schemas.companies.read',
+      'crm.schemas.deals.read',
+      'crm.objects.owners.read',
+      'crm.objects.quotes.read',
+      'crm.schemas.quotes.read',
+      'crm.objects.line_items.read',
+      'crm.schemas.line_items.read',
+    ]);
+    expect(scopes).not.toContain('marketing.email.write');
+  });
+});

src/modules/oauth/passport-strategies/hubspot-strategy.ts

@@ -17,7 +17,7 @@ export class HubspotStrategy extends PassportStrategy(Strategy) {
         clientSecret: oauthSecrets.hubspot.client_secret,
         callbackURL: oauthSecrets.hubspot.redirect_uri,
         scope:
-          'tickets automation business-intelligence oauth forms integration-sync sales-email-read crm.lists.read crm.objects.contacts.read crm.schemas.contacts.read crm.objects.companies.read crm.objects.deals.read crm.schemas.companies.read crm.schemas.deals.read crm.objects.owners.read crm.objects.quotes.read crm.schemas.quotes.read crm.objects.line_items.read crm.schemas.line_items.read',
+          'tickets automation business-intelligence oauth forms content integration-sync sales-email-read crm.lists.read crm.objects.contacts.read crm.schemas.contacts.read crm.objects.companies.read crm.objects.deals.read crm.schemas.companies.read crm.schemas.deals.read crm.objects.owners.read crm.objects.quotes.read crm.schemas.quotes.read crm.objects.line_items.read crm.schemas.line_items.read',
         passReqToCallback: true,
       },
       (accessToken, refreshToken, tokenInfo, profile, done) => {

tsconfig.build.json

@@ -1,4 +1,4 @@
 {
   "extends": "./tsconfig.json",
-  "exclude": ["node_modules", "test", "dist", "**/*spec.ts", "jest.config.ts"]
+  "exclude": ["node_modules", "test", "dist", "**/*spec.ts", "jest.*.ts"]
 }